bug: Setting transparency = false still has transparency

[mizlan]

Neovim version (nvim -v)

v0.10.0-dev-1999+g6f6abd8c0

Terminal / multiplexer

Neovide

Describe the bug

Seems like blend is still used when transparency is disabled

Repro

require('rose-pine').setup({
        dark_variant = 'moon',
        disable_italics = true,
        styles = {
          bold = true,
          italic = true,
          transparency = false,
        },
...

[mvllow]

Could you elaborate on what blend you mean? If your window is transparent that's unrelated. Screenshots would be helpful :)

[mizlan]

Sure, sorry, was in a hurry when I posted the original issue. I use Neovide, which currently doesn't render blend properly, because it will bleed the desktop wallpaper through. Here is the link issue, which has a screenshot: neovide/neovide#2327 I tried disabling blend in the colorscheme with

        highlight_groups = {
...
          GitSignsAdd                = { fg = "#bacfc4" },
          GitSignsChange             = { fg = "#e6d2c1" },
          GitSignsDelete             = { fg = "#dbb6b4" },
...

and with both 0 and 100 values, but it doesnt work. Also, like i said in the original comment, disabling transparency doesnt seem to work either.

[mvllow]

Oh I see, appreciate the extra info. This could definitely be improved from our side once I have some time but until then:

highlight_groups = {
          GitSignsAdd                = { fg = "#bacfc4", inherit = false },
          GitSignsChange             = { fg = "#e6d2c1", inherit = false },
          GitSignsDelete             = { fg = "#dbb6b4", inherit = false },
}

By default, these groups are being merged with the groups from the theme. Setting inherit = false should fix your issue for those groups at least. Note, you may need to update the background as well.

[mizlan]

Seems that it's still occurring

[mvllow]

It looks like Neovide might handle this via neovide/neovide#2471

After re-reading the initial issue you linked, though, I realised that we are using the blend property but never intended it to actually blend via Neovim's API—we take the blend value and apply our own logic to have a colour that looks blended. In short, adding blend = 1 or blend = 0 (not able to test at the moment) to the groups mentioned above may fix this.

[mizlan]

I don't think either works

[shivajreddy]

Yup, transparency = true is not working. other themes do have working transparency

[mvllow]

@shivajreddy that sounds like another issue since this issue is about false not working. What are you seeing to say true is also not working?