Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignettes needed #105

Open
elinw opened this issue Jun 11, 2017 · 9 comments
Open

Vignettes needed #105

elinw opened this issue Jun 11, 2017 · 9 comments

Comments

@elinw
Copy link
Collaborator

elinw commented Jun 11, 2017

We could use some good vignettes of both simple and advanced use.

@elinw
Copy link
Collaborator Author

elinw commented Sep 25, 2017

A couple of vignettes are now in the develop branch, but they could definitely be expanded.

@elinw
Copy link
Collaborator Author

elinw commented Oct 13, 2017

For example we could use vignettes on how to use the individual functions or how to do printing (though that is a bit complex, it would be great for someone to start it off at least.) Don't feel you need to write everything.

@elinw
Copy link
Collaborator Author

elinw commented Dec 15, 2017

We need to update the vignettes with new features.

@elinw
Copy link
Collaborator Author

elinw commented Dec 18, 2017

We have good basic vignettes but it would be nice to add more extended examples of use cases. This might go into a third vignette if someone would like to create it.

@elinw
Copy link
Collaborator Author

elinw commented Feb 13, 2019

Add a vignette about working with skimr +dplyr.

@elinw
Copy link
Collaborator Author

elinw commented Nov 9, 2019

We're pretty good on the basics but could still use others addressing specific tasks that people do with skimr (such as make variable summary tables for papers).

@kylebutts
Copy link
Contributor

For the supporting additional objects vignette:

  1. There is no need to have an sfc_MulitX for each class. All the classes inherit sfc class and skimr is able to work fine with:
    skim_sf <- skim_with(
    sfc = sfl(
    n_unique = n_unique,
    valid = ~ sum(sf::st_is_valid(.))
    )
    )

  2. I think a function that is simple without being silly is:

get_crs <- function(column){
crs <- sf::st_crs(column)

paste0("epsg: ", crs[["epsg"]], " proj4string: '", crs[["proj4string"]], "'")
}

I have an updated .Rmd, if you think think that will be helpful for the vignette.

@michaelquinn32
Copy link
Collaborator

Thanks for the suggestion!

Please check the contribution guide and open a pull request. We can discuss particulars in the updated version of the Rmd.

@kylebutts
Copy link
Contributor

I have opened a pull request @michaelquinn32! #575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants