Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it intentional that everything what Linker writes into stderr is treated as error #24

Open
piomis opened this issue Mar 18, 2022 · 4 comments

Comments

@piomis
Copy link

piomis commented Mar 18, 2022

One of my compier/linker wrappers writes some "banner" info to stderr (but exit code is 0 - so process is successful).
I have noticed that this info is logged during building and displayed again after whole build.

What is more interesting that Compile step uses XBuildLogProvieder.LogOther method which things which do not fit into none of regexp treats as Warnings.
But Linker step calls XBuildLogProvider.LogLinker whch things which do not match any regexp logs es errors.
Is it intentional?

@roozbehid
Copy link
Owner

roozbehid commented Mar 18, 2022

Yeah. So mostly I wrote this for my webassembly project so I can build my stuff for webassembly and I think everything that emscripten linker was puting out shouldve been treated as errors.
But honestly I dont recall it anymore.

But overall my problem with all these categorization of logs was they were not consistent among different compilers. So eventually what you see is what made my compilers and me happy for my few projects.
I really appreciate a PR if you think behavior can be enhanced.

And Also I will pish new version ASAP

@piomis
Copy link
Author

piomis commented Mar 18, 2022

I will try to think about it - maybe configurable regexp would do the job.

In regards to push - maybe you would like to check hanging PR before making new release on nuget.org :)

@roozbehid
Copy link
Owner

I pushed 1.22.77.8

@roozbehid
Copy link
Owner

Thanks to you first update after 3 years :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants