Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait option #71

Open
roniemartinez opened this issue Mar 12, 2022 · 0 comments
Open

Add wait option #71

roniemartinez opened this issue Mar 12, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects

Comments

@roniemartinez
Copy link
Owner

Some JS-enabled websites has multiple pop-ups (agree dialog -> newsletter dialog -> subscribe dialog -> now you can use the website) and these dialogs takes time. Adding wait will make sure that the setup handlers will wait first.

Option 1: Explicit

@select(text="AGREE", setup=True, wait=1000)  # or wait_for="visible"
def handler(element, page):
    with page.expect_navigation():
        element.click()

Option 2: Implicit

This will be done in the background by Dude

@roniemartinez roniemartinez added enhancement New feature or request help wanted Extra attention is needed labels Mar 12, 2022
@roniemartinez roniemartinez added this to To do in The Dude Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Development

No branches or pull requests

1 participant