noConstantCondition and while(true) {}

[Conaclos]

Using the constant condition true in a while loop seems a common idiom in JavaSCript:

while (true) {
  if (someCondition) {
    break;
  }
}

On the Typescript Compiler code-base it appears 94 times.

I think we could relax noConstantCondition to allow this idiom.

Opinions?

[ematipico]

How do you propose to relax the condition? An option? Or with a specific check?

[Conaclos]

Just a specific check that allows true constant condition in while.
This is a very simple change.

This could diverge from the ESlint implementation.
However, this seems unlikely that while (true) is a mistake. This looks like a deliberate choice.

[ematipico]

I don't mind diverging from ESLint, Rome is not meant to be a 1:1 copy of ESLint.

[Conaclos]

Let's just think some days about that before proposing a PR.