Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node binding typing relies on rollup types #439

Closed
yyx990803 opened this issue Mar 6, 2024 · 1 comment
Closed

Node binding typing relies on rollup types #439

yyx990803 opened this issue Mar 6, 2024 · 1 comment

Comments

@yyx990803
Copy link
Member

But rollup isn't installed as a dependency, so we lose type inference in most places.

Since we don't really want rollup as a dependency (only its types), we either need a way to bundle rollup types or have to copy the relevant types over. (The latter probably necessary as that also allows us to provide more accurate types in cases where there are properties / APIs that we do not yet support)

@hyf0
Copy link
Member

hyf0 commented Mar 6, 2024

+1. Luckly we could just use the rollup's bundled .d.ts file.

@hyf0 hyf0 closed this as completed in e231e14 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants