You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It means accessing the level in Rollbar::Logger raises an exception. Rollbar::Logger should probably also use the level accessor (instead of the instance variable) to be more resilient to these kinds of improvements/changes to the base ::Logger.
And while I understand the point of raising exceptions on formatter, etc; it means the Logger doesn't play well with the newer Rails logger broadcast functionality which tries to copy formatters down to any new broadcast children.
The text was updated successfully, but these errors were encountered:
Rollbar::Logger inherits from ::Logger, but doesn't call it's constructor.
logger gem v1.6.0 (which, for instance, comes with ruby 3.3.1) initializes other parameters in that constructor which are used in other methods (like the level accessor).
It means accessing the
level
in Rollbar::Logger raises an exception. Rollbar::Logger should probably also use the level accessor (instead of the instance variable) to be more resilient to these kinds of improvements/changes to the base ::Logger.And while I understand the point of raising exceptions on formatter, etc; it means the Logger doesn't play well with the newer Rails logger broadcast functionality which tries to copy formatters down to any new broadcast children.
The text was updated successfully, but these errors were encountered: