Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollbar::Logger not working well with the newest logger gem #1156

Open
randypuro opened this issue May 3, 2024 · 0 comments
Open

Rollbar::Logger not working well with the newest logger gem #1156

randypuro opened this issue May 3, 2024 · 0 comments
Assignees
Labels

Comments

@randypuro
Copy link

Rollbar::Logger inherits from ::Logger, but doesn't call it's constructor.

logger gem v1.6.0 (which, for instance, comes with ruby 3.3.1) initializes other parameters in that constructor which are used in other methods (like the level accessor).

It means accessing the level in Rollbar::Logger raises an exception. Rollbar::Logger should probably also use the level accessor (instead of the instance variable) to be more resilient to these kinds of improvements/changes to the base ::Logger.

And while I understand the point of raising exceptions on formatter, etc; it means the Logger doesn't play well with the newer Rails logger broadcast functionality which tries to copy formatters down to any new broadcast children.

@linear linear bot added the Ruby label May 3, 2024
@waltjones waltjones self-assigned this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants