Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More weather providers #14

Open
rocksdanister opened this issue Oct 3, 2023 · 8 comments
Open

More weather providers #14

rocksdanister opened this issue Oct 3, 2023 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rocksdanister
Copy link
Owner

rocksdanister commented Oct 3, 2023

Currently supported Weather providers:

  • Qweather
  • Open-meteo
  • OpenWeatherMap

Weather client implementation is abstracted.
More providers can be added by creating new client implementation.

The weather data is processed as detailed here.

Example showing new weather client implementation.

Community contributions are welcome.

@rocksdanister rocksdanister added enhancement New feature or request good first issue Good for newcomers labels Oct 3, 2023
@itsWindows11
Copy link

Does the abstraction count cases like if a specific weather API doesn't provide certain types of data? Think free OpenWeatherMap API for example.

@rocksdanister
Copy link
Owner Author

rocksdanister commented Oct 3, 2023

It should return null then or better multiple providers can be combined into a single client implementation.

image

Most UI controls have null checks and will show placeholder but will need to recheck.

@SurfaceSystems
Copy link

in the weather graph you can put the most common weather of the day, like a summary of how the time is going to be

@Gatorzgaming
Copy link

Gatorzgaming commented Jan 20, 2024

Working on this, I got locations being pulled from open street map so far, copilot is super useful, I have only done unity C# so its been teaching me a lot about UWP. https://github.com/Gatorzgaming/weather
image
image
image

@Livins1
Copy link
Contributor

Livins1 commented Feb 26, 2024

Hi,i am wondering if i can add a weather provider from chinese mainland to improve the user experience and solve some problem cause by network lag.
the providers are like: https://lbs.amap.com/api/webservice/guide/api/weatherinfo
https://seniverse.yuque.com/hyper_data/api_v3/intro

@Gatorzgaming
Copy link

Depending on the data it collects and a few other factors, you are welcome to fork the project and try it out for yourself; if you get it working, send a pull request, and it will be assessed more closely than I would imagine. Disclaimer: I am not the repo owner; don't take this as fact.

@rocksdanister
Copy link
Owner Author

Pull requests are welcome.

If you need help or have doubts about how to program new weather provider try creating a discussion.

@Livins1
Copy link
Contributor

Livins1 commented Mar 25, 2024

Thanks for reply, i am making some progress. and if i need some help , i will let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants