Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift flags is hidden #273

Closed
caruccio opened this issue May 6, 2024 · 1 comment · Fixed by #274
Closed

Openshift flags is hidden #273

caruccio opened this issue May 6, 2024 · 1 comment · Fixed by #274

Comments

@caruccio
Copy link

caruccio commented May 6, 2024

The --openshift flag is hidden from the help message. Why is that?

@aantn
Copy link
Contributor

aantn commented May 7, 2024

I don't think there's a good reason. I've opened a PR to fix it.

I suspect this was done originally because the flag was intended for internal use, when KRR is run by Robusta runner in-cluster. (As opposed to the usual flow where KRR is run outside of the cluster.)

But there is no reason not to expose it more broadly if someone wants to run KRR standalone inside an openshift cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants