Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check protected data member #69

Open
claudiofantacci opened this issue May 14, 2019 · 3 comments
Open

Double check protected data member #69

claudiofantacci opened this issue May 14, 2019 · 3 comments

Comments

@claudiofantacci
Copy link
Collaborator

Many classes have way too much protected data member that should probably be moved in private scope. See for example GaussianMixture and derived classes.

cc @xEnVrE

@xEnVrE
Copy link
Collaborator

xEnVrE commented May 15, 2019

See this for reference.

@claudiofantacci
Copy link
Collaborator Author

The current library rework is addressing this.
The main problem seems related to GaussianMixture and derived classes where we need to carefully think about the consequences of this change.

@claudiofantacci
Copy link
Collaborator Author

To date, if you change the scope of

unsigned int num_particle_;
std::size_t state_size_;
ParticleSet pred_particle_;
ParticleSet cor_particle_;

in SIS.h it becomes difficult to inherit from it (obviously, we don't have proper interfaces to those data). As a matter of fact, the user cannot access that data at all and this is no longer acceptable as they are the product of the class itself. I'm going to change this behavior.

@xEnVrE we need to discuss GaussianMixture f2f asap.

@claudiofantacci claudiofantacci added this to the 0.9.0 milestone May 16, 2019
@xEnVrE xEnVrE removed this from the 0.9.0 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants