Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IconAnnotator] - mark objects with custom icons / images #460

Open
SkalskiP opened this issue Oct 12, 2023 · 9 comments · May be fixed by #930
Open

[IconAnnotator] - mark objects with custom icons / images #460

SkalskiP opened this issue Oct 12, 2023 · 9 comments · May be fixed by #930
Assignees
@dfreilich
Labels
api:annotator Annotators enhancement New feature or request good first issue Good for newcomers Q1.2024 Tasks planned for execution in Q1 2024.

Comments

@SkalskiP
Copy link
Collaborator

SkalskiP commented Oct 12, 2023 •
edited

Description

Create IconAnnotator - whose task is to mark objects related to sv.Detections with custom icons.

273726799-6b0ea345-bb22-4c3d-9e67-6a91371f852e

It should also allow you to control the icon position in relation to the box using sv.Position.

API

class IconAnnotator(BaseAnnotator):

    def __init__(
        self,
        icon_path: str,
        position: Position = Position.TOP_CENTER
    ):
        pass

    def annotate(
        self,
        scene: np.ndarray,
        detections: Detections,
    ) -> np.ndarray:
        pass

Additional

  • Note: Please share a Google Colab with minimal code to test the new feature. We know it's additional work, but it will definitely speed up the review process. Each change must be tested by the reviewer. Setting up a local environment to do this is time-consuming. Please ensure that Google Colab can be accessed without any issues (make it public). Thank you! 🙏🏻
@SkalskiP SkalskiP added enhancement New feature or request good first issue Good for newcomers api:annotator Annotators hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti labels Oct 12, 2023
@SkalskiP SkalskiP changed the title Create IconAnnotator Create sv.IconAnnotator Oct 12, 2023
@SkalskiP SkalskiP mentioned this issue Oct 12, 2023
Closed
@Rajarshi-Misra
Copy link
Contributor

@SkalskiP I'm interested in working on this one.

@SkalskiP
Copy link
Collaborator Author

@Rajarshi-Misra you are assigned!

@Shishuii
Copy link

Shishuii commented Nov 3, 2023

@SkalskiP Is this still available ? I would be glad to contribute to this. :)

@onuralpszr
Copy link
Collaborator

@Shishuii I am re-assigning to you. You can start working on it.

@Shishuii
Copy link

Shishuii commented Nov 5, 2023 •
edited

Hi @onuralpszr ,
Below is the final output of IconAnnotator. (I have added the box annotations just for visualization)
Shall I submit a PR for review?
final_ouput_v2

@onuralpszr
Copy link
Collaborator

@Shishuii looking nice do please PR let's talk about on PR as well.

@Shishuii Shishuii mentioned this issue Nov 5, 2023
Closed
1 task
@Shishuii
Copy link

Shishuii commented Nov 6, 2023

Hi @onuralpszr ,
Please review the PR.
The PR can be tested on this colab link :
https://colab.research.google.com/drive/1rjwO76QwA-W5WhA0Tvy3uSFtmCtbd9rA?usp=sharing

@Shishuii Shishuii mentioned this issue Nov 6, 2023
Open
1 task
@SkalskiP SkalskiP added Q1.2024 Tasks planned for execution in Q1 2024. and removed hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti labels Jan 26, 2024
@SkalskiP SkalskiP changed the title Create sv.IconAnnotator [IconAnnotator] - mark objects with custom icons / images Jan 26, 2024
@dfreilich
Copy link

@SkalskiP I'd like to take this (based on the work in #579).

@dfreilich dfreilich linked a pull request Feb 20, 2024 that will close this issue
Open
4 tasks
@SkalskiP
Copy link
Collaborator Author

Hi @dfreilich 👋🏻 ! I'm very sorry for the late response. I was a bit busy with other duties. I'm looking at your PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreilich dfreilich

Labels
api:annotator Annotators enhancement New feature or request good first issue Good for newcomers Q1.2024 Tasks planned for execution in Q1 2024.
Projects
Supervision Q1 2024
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[IconAnnotator] - Add IconAnnotator to Mark Objects with Custom Icons/Images dfreilich/supervision
5 participants
@onuralpszr @dfreilich @Shishuii @SkalskiP @Rajarshi-Misra