Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on 3x devices? #43

Open
zenghaojim33 opened this issue Oct 9, 2020 · 6 comments
Open

Doesn't work on 3x devices? #43

zenghaojim33 opened this issue Oct 9, 2020 · 6 comments

Comments

@zenghaojim33
Copy link

The demo works great on simulators and 2x scale devices but it looks strange on 3x devices. Any idea how to fix this?

@roberthein
Copy link
Owner

I see what you mean.. 🤔
Let me investigate this.

Thank you for reporting @zenghaojim33! 🙏

@zenghaojim33
Copy link
Author

Thanks for quick reply! So confused why iPhone X and iPhone XR look completely different...

@zenghaojim33
Copy link
Author

I think I know the reason. shouldInvalidateLayout(forBoundsChange newBounds: CGRect) called not as frequently on some devices (maybe OS versions, not sure) as the simulators did which makes the animtor get the wrong newBounds. Dont know how solve this problem in a custom layout, I think I have to calculate the delta in scrollViewDidScroll as a work around.

@roberthein
Copy link
Owner

I'll also try to find some time to check this.. thank you.

@shimunKg
Copy link

shimunKg commented Mar 11, 2021

@roberthein Has anyone found a solution for this issue?

@shimunKg
Copy link

I think I know the reason. shouldInvalidateLayout(forBoundsChange newBounds: CGRect) called not as frequently on some devices (maybe OS versions, not sure) as the simulators did which makes the animtor get the wrong newBounds. Dont know how solve this problem in a custom layout, I think I have to calculate the delta in scrollViewDidScroll as a work around.

have you got some solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants