Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not able to change Timezone #53

Open
link2arslan opened this issue Sep 20, 2022 · 4 comments
Open

not able to change Timezone #53

link2arslan opened this issue Sep 20, 2022 · 4 comments

Comments

@link2arslan
Copy link

link2arslan commented Sep 20, 2022

Hi, i am using this package and the documentation of this package says i can change timezone with the config file. I have tried but timezone is not picking value from package configuration file (SCHEDULE_TIMEZONE ).

Also i want to put timezone according to user. is there a way to pass timezone in the $schedule array when creating new schedule?

Thankyou

@robersonfaria
Copy link
Owner

Hello, unfortunately I'm working on several projects at the moment and I'm not able to give this package enough attention.
Please open a pull request with your suggestion, if possible with automated tests, which I will be happy to approve.

@link2arslan
Copy link
Author

link2arslan commented Oct 26, 2022

I was just busy completing my project but now I have created a pull request and You can review it. I have added a select list when creating a new job, the user can select a timezone. Also added a code to schedule the jobs according to its timezone.

@robersonfaria
Copy link
Owner

Hi, thank you very much for your contribution.

Unfortunately your PR broke several tests, I did a quick debug to try to understand why and I believe it's because of the PHP/Laravel version but I still couldn't look more closely to solve it, as soon as possible I'll try to solve it to receive your PR, but If you can solve it sooner, thanks again.

@link2arslan
Copy link
Author

Hello, I have updated a code.
But i have a concerns recording to recreate database in unit test. Because i have created one column in schedule table and also created a migration for it.

Please check this database issue. Beacuae it doesn't created the column with my migration file.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants