Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify if a threaded message should fetch the channel instead #24

Open
mwarkentin opened this issue Dec 14, 2022 · 2 comments
Open

Specify if a threaded message should fetch the channel instead #24

mwarkentin opened this issue Dec 14, 2022 · 2 comments

Comments

@mwarkentin
Copy link

mwarkentin commented Dec 14, 2022

Hi, I'm back again. :)

It would be nice if there was a way to fetch the channel history starting with a message which was itself a thread - gh-slack seems to detect that it's a thread and only pull the thread content instead.

Example:

image

It seems like it would make sense to maintain that default functionality but having a way to specify that it should fetch the channel instead (--channel or --fetch-channel) would work?

I also have a bigger related request but I'll add that in a separate issue (#25).

@rneatherway
Copy link
Owner

Welcome back!

Yes, you're right. The current behaviour is really just a simple method of getting what I wanted at the time. In practice I pretty much always archive threads, but perhaps that just works for me because that's the way we use Slack.

Actually there are some existing problems with the current heuristics, like if you try to fetch a message in a thread that isn't the first one, it isn't detected as being in a thread and then fetches some unrelated messages from around the same time from the channel 🤦

Bottom line: I would be completely open to options for fine-tuning the behaviour like you suggest. --channel sounds a bit like you might use it to specify the channel independently of the permalink, but apart from that is good. I like that it is shorter than --fetch-channel. If you want to make a PR I'll help review and get it over the line.

@mwarkentin
Copy link
Author

Actually there are some existing problems with the current heuristics, like if you try to fetch a message in a thread that isn't the first one, it isn't detected as being in a thread and then fetches some unrelated messages from around the same time from the channel

This should be fixed now by #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants