Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen redrawing issues #234

Open
rsekman opened this issue Jun 7, 2023 · 1 comment
Open

Screen redrawing issues #234

rsekman opened this issue Jun 7, 2023 · 1 comment

Comments

@rsekman
Copy link
Contributor

rsekman commented Jun 7, 2023

A recent urwid update changed how/when the screen is redrawn, which made commits 030508e f83949f a48ef30 necessary.

However, there are still some problems remaining. The ones I have noticed are with the interactive command and the tab command. These were not present before the urwid update. I am on Arch and urwid version 2.1.2.r56.gabc098c-1 (urwid/urwid@abc098c).

interactive command

To reproduce:

  • open a torrent list
  • hit / (default keybind) to open the interactive limit prompt
  • the prompt appears after a noticeable delay instead of, well, promptly
  • if one enters, say, /a the prompt appears after the second keystroke

I opened #233 to fix this.

tab command

To reproduce:

  • open a torrent list
  • hit <enter> (default keybind) to open a torrent tab
  • the tab appears only after a noticeable delay
  • pressing any key after <enter> makes the tab appear promptly, similarly to the interactive case
  • press d to close the tab
  • the tab is closed only after a noticeable delay
  • again, the effect can be made to take place promptly by pressing any key after d

Any command that opens a tab works to reproduce, e.g. tab help ls.

This one is trickier. We can't just decorate TabCmd.run because the tab may need to wait for data before rendering (e.g. info). Also, if the rc opens tabs on startup, exceptions are raised because there isn't an eventloop yet. So some more sophisticated logic is needed, but I'm not sure what it is.

@rsekman
Copy link
Contributor Author

rsekman commented Jun 7, 2023

After looking more closely at the code I've come up with much better and more comprehensive solutions #235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant