-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen redrawing issues #234
Comments
After looking more closely at the code I've come up with much better and more comprehensive solutions #235. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A recent
urwid
update changed how/when the screen is redrawn, which made commits 030508e f83949f a48ef30 necessary.However, there are still some problems remaining. The ones I have noticed are with the
interactive
command and thetab
command. These were not present before theurwid
update. I am on Arch andurwid
version2.1.2.r56.gabc098c-1
(urwid/urwid@abc098c).interactive
commandTo reproduce:
/
(default keybind) to open the interactive limit prompt/a
the prompt appears after the second keystrokeI opened #233 to fix this.
tab
commandTo reproduce:
<enter>
(default keybind) to open a torrent tab<enter>
makes the tab appear promptly, similarly to theinteractive
cased
to close the tabd
Any command that opens a tab works to reproduce, e.g.
tab help ls
.This one is trickier. We can't just decorate
TabCmd.run
because the tab may need to wait for data before rendering (e.g.info
). Also, if therc
opens tabs on startup, exceptions are raised because there isn't an eventloop yet. So some more sophisticated logic is needed, but I'm not sure what it is.The text was updated successfully, but these errors were encountered: