Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR code review guidelines #8

Open
rborn opened this issue Mar 26, 2019 · 6 comments
Open

PR code review guidelines #8

rborn opened this issue Mar 26, 2019 · 6 comments
Labels
discussion Let's talk about stuff

Comments

@rborn
Copy link
Collaborator

rborn commented Mar 26, 2019

We should mention in the guidelines that anyone can review the PRs (to free some load from the maintainers) but int he same time the release and merge procedures are restricted so we can keep the builds in a working state.

@kelset kelset added the discussion Let's talk about stuff label Mar 26, 2019
@kelset
Copy link
Contributor

kelset commented Apr 2, 2019

@orta posted an RFC to add Peril to the org here, maybe it's something that we can use to enforce said rules? (once we define them?)

@rborn
Copy link
Collaborator Author

rborn commented Apr 2, 2019

@kelset @orta didn't know about peril, I'll have a deeper look but it looks good at a first glance 🤗

@orta
Copy link

orta commented Apr 2, 2019

I think most of the these discussion issues could be verified with a daily task in Peril

@kelset
Copy link
Contributor

kelset commented Apr 2, 2019

For context, here's Peril's repo https://github.com/danger/peril#i-want-to-use-peril

Btw @orta in that section it says that basically we'd need to self-host. Any suggestions on that?

Should we follow this? https://github.com/danger/peril/blob/master/docs/setup_for_org.md

@orta
Copy link

orta commented Apr 2, 2019

Nah, don't self-host - run on Peril staging. I can hook that up 👍

@orta
Copy link

orta commented Apr 4, 2019

@kelset can you make a repo called peril-settings for this org? Then I can do the rest I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Let's talk about stuff
Projects
None yet
Development

No branches or pull requests

3 participants