Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have a drawing pad or signature pad? #53

Open
hmheng opened this issue Jul 29, 2019 · 5 comments
Open

Can we have a drawing pad or signature pad? #53

hmheng opened this issue Jul 29, 2019 · 5 comments
Labels
discussion Let's talk about stuff

Comments

@hmheng
Copy link

hmheng commented Jul 29, 2019

Feature Request

There is react-native-signature-signature-pad or some other drawing pad, those are great but they are quite outdated now. May we have them be improved and included in react-native-community package? Also can we have it for RN for Windows and RN for Web support too?

https://github.com/RepairShopr/react-native-signature-capture

@mikehardy
Copy link
Collaborator

I think the idea of the react-native-community is a collection of people working together on their own software, not a pool of labor that will build some other software on demand

I think the path to having software hosted in react-native-community is more like:

  • make sure your software works well with current versions
  • commit to maintaining it, so it will see attention from you
  • show that to be the case with a reasonable following, and reasonable maintenance for a while
  • ask to have your reasonably-well-maintained, working repository hosted under the community umbrella

In short - make useful software and demonstrate a commitment to it.

That's my impression anyway

@hmheng
Copy link
Author

hmheng commented Jul 29, 2019

Hi Mike,

Thanks for your prompt. I didn't expect my suggestion sounds rude to you.
with respect to the community and appreciate what community had done, I didn't treat anyone here as labour. What I suggested is only what I think it might be useful for others, so the entire community can consider to do since the library that I mention is quite dated. Of course, I am still quite new to the RN.

If there is clear guide how to build plugin for multiple platforms, I would love to do and contribute it with my capacity.

Hope you understand.

Thank you.

@mikehardy
Copy link
Collaborator

No worries - I didn't think it was rude, I just wanted to put forward that it's more about help with work vs requests, and I the path I outlined is (I think?) about the path I've seen software take to get there. I'm not aware of clear guides per se, but the path I've taken is to just start working on the software you need. You mentioned a package that had potential but was outdated - start by updating it and go from there I think

@hmheng
Copy link
Author

hmheng commented Jul 29, 2019

Hopefully I have some ideas how to develop it further though. Hope more people can guide me on how to achieve that.

@kelset
Copy link
Contributor

kelset commented Aug 14, 2019

👋 @hmheng, to further explain how it works, there is currently this issue -> #34

The library you linked is owned by someone other than you, so you should first get this person to give you rights to do that and then we could try and follow what written in the other issue I linked above.

All of this said, what @mikehardy mentioned above is also correct, we are still finding the right balance before writing it in the guidelines - sorry if it caused confusion!

@kelset kelset added the discussion Let's talk about stuff label Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Let's talk about stuff
Projects
None yet
Development

No branches or pull requests

3 participants