Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty item in selectbox for enum is not visible #4197

Open
4 tasks done
Vity01 opened this issue May 20, 2024 · 2 comments · May be fixed by #4200
Open
4 tasks done

Empty item in selectbox for enum is not visible #4197

Vity01 opened this issue May 20, 2024 · 2 comments · May be fixed by #4200
Assignees
Labels

Comments

@Vity01
Copy link

Vity01 commented May 20, 2024

Prerequisites

What theme are you using?

material-ui

Version

5.x

Current Behavior

Although the enum property in the model is nullable and not required, empty value for selection is missing.

Nowadays there is no easy way for user to deselect already selected value. We use 'blank space' as an empty item and it's barely visible and also it's not a perfect engineering solution.

It's working for other than Material-UI
eg: working combobox:
In RJSF demo

For default theme, you can see an empty available item
image

Not not for the MaterialUI:
image
RJSF DEMO - bug

Expected Behavior

Empty item should available also for MaterialUI

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

Anything else?

No response

@Vity01 Vity01 added bug needs triage Initial label given, to be assigned correct labels and assigned labels May 20, 2024
@Vity01 Vity01 changed the title Empty values are not available Empty item in selectbox for enum is not visible May 20, 2024
@kevinmichaelchen
Copy link

kevinmichaelchen commented May 22, 2024

It would be great if deselection and nullable enums were supported.

I'm sure my company would gladly contribute to an Algora bounty if such a thing were available.

@heath-freenome
Copy link
Member

@Vity01 @kevinmichaelchen Great catch. The core theme built in an unselect capability that is similar to what the core theme does in all of the other themes. Hopefully we can get a fix up for this in the next week or so.

@heath-freenome heath-freenome removed the needs triage Initial label given, to be assigned correct labels and assigned label May 24, 2024
@nickgros nickgros self-assigned this May 24, 2024
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants