Double rendering on some components

[damusix]

Help us to manage our issues by answering the following:

1. Describe your issue:

Sometimes, randomly, a component will double the elements inside of it.

2. Can you reproduce the issue?

No, but I have screenshots of the issue

3. On which browser/OS does the issue appear?

Latest chrome

4. Which version of Riot does it affect?

Riot 7

5. How would you tag this issue?

• Bug

[GianlucaGuarini]

I have tried to replicate the issue with this demo https://plnkr.co/edit/icOhGsihhg5y4MWQ but I had no luck so far. Are you sure that your html is valid and you are closing your tags properly?

[damusix]

@GianlucaGuarini I think I know why it's happening, I just can't replicate.

The above is a different context under which the double renders are happening. Below is another specific scenario:

• I have a custom built router on my app.
• I riot.install(...) an enhancer that, onMounted, it redirects to whatever component.defaultRoute is.
• I also expose the router via window.router

Given the following:

{ 
    onMounted() { window.router.goTo('/somewhere'); }, 
    defaultRoute: '/somewhere/else' 
}

I get the double render issue.

What I posted up top is similar, but a different reason as to why it double renders (still looking for the first one)

I think something might be happening where it fails to clean up the old HTML elements or they are overwritten when there are too many rerender attempts.

My router is simple:

route.riot

<route>

    <template if="{ shouldShow() }">
        <slot />
    </template>

    <script>
        export default {
            ...,
            shouldShow() {

                if (currentRoute does not match this.path) {
                     return false;
                }

                return true;
            }
        }
    </script>
</route>

and the thing that listens to a route change simply re-renders the component using routeComponent.update({ show:true })

... anyway, that's just context to explain that, something is going on that it's not cleaning up old HTML and rendering next to it.

[GianlucaGuarini]

Also with the code provided I am not able to reproduce the issue https://plnkr.co/edit/3wWRvhDsDy5MWrXR. Without a reproducible example it's really hard for me to help you out. I will keep this issue open in case someone else could come out with a better idea