Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook Support on latest Riot version. #2958

Open
1 of 7 tasks
nibushibu opened this issue Jun 13, 2022 · 6 comments
Open
1 of 7 tasks

Storybook Support on latest Riot version. #2958

nibushibu opened this issue Jun 13, 2022 · 6 comments

Comments

@nibushibu
Copy link
Member

Help us to manage our issues by answering the following:

  1. Describe your issue:

There is an issue in Storybook repository, Storybook does not seem to support the latest Riot.js.

storybook-eol/riot#1

  1. Can you reproduce the issue?
  1. On which browser/OS does the issue appear?
  1. Which version of Riot does it affect?

v4 and later

  1. How would you tag this issue?
  • Question
  • Bug
  • Discussion
  • Feature request
  • Tip
  • Enhancement
  • Performance
@GianlucaGuarini
Copy link
Member

I started working on it here storybookjs/storybook#18672 We need to be sure that the storybook team will accept Riot.js into its core.

@GianlucaGuarini
Copy link
Member

GianlucaGuarini commented Jul 13, 2022

According to the discord chat I had with @shilman the storybook team needs a maintainer for the RIot.js addon.
They are not interested in maintaining the addon themselves.
Storybook 7 will change heavily the addons API and the documentation is not yet available online, so this means that its development will require several days.

Since I already have to maintain ~30 Riot.js modules, the storybook addon development and maintenance would be too much for me. Storybook is not interested in sponsoring the development of the addon and they are just looking for an external maintainer for the job.

I need someone from the Riot.js community that is interested in working on it, I will provide my guidance and support if needed. If you are interested you can submit your expenses here and I will be glad to sponsor your work.
Unfortunately I can't do everything myself.

@nibushibu
Copy link
Member Author

Thank you for considering and researching!
I understand the situation better now.
I will try to recruit someone who can help it as much as I possible.

@GianlucaGuarini GianlucaGuarini removed their assignment Aug 4, 2022
@kachurunus
Copy link
Contributor

I agree, Storybook support is exactly what I need right now

@nibushibu
Copy link
Member Author

@kachurunus I agree. 👍
In addition, I do not want to place an undue burden on @GianlucaGuarini, who continues to develop Riot, and I feel that Storybook support needs to be accomplished by the community.
If you or anyone around you is willing to help, I would be happy to spread the word about this thread.
#2958 (comment)

@GianlucaGuarini
Copy link
Member

I will work on the Riot.js router and animations in future. I am sorry but I have no time to work on the storybook plugin as well. The implementation should be trivial with the current Riot.js API though. Let me know if you have questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants