Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing URL encoding #228

Closed
asardaes opened this issue May 15, 2024 · 3 comments
Closed

Missing URL encoding #228

asardaes opened this issue May 15, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@asardaes
Copy link

Describe the bug
I have a GET endpoint that contains a path parameter whose values may include a # symbol. The request fails unless I manually change said symbol to %23.

To Reproduce
You would need an upstream component that processes the request and notifies what it receives.

Expected behavior
URL encoding should happen automatically, although it might have to be configurable? I'm not sure about edge cases.

Environment (if possible, copy the information from the error dialog or the About menu):

  • OS: MacOS
  • Kreya Version 1.14.0

Additional context

@asardaes asardaes added the bug Something isn't working label May 15, 2024
@CommonGuy
Copy link
Contributor

Yes, this should happen automatically in path parameters and was an oversight. We'll fix this

@CommonGuy CommonGuy added status:doing We are working on this status:waiting-for-release Implemented, waiting for next stable release and removed status:doing We are working on this labels May 15, 2024
@CommonGuy
Copy link
Contributor

This has been fixed in the latest beta version and will be released in the next stable version

@CommonGuy
Copy link
Contributor

Kreya 1.15 has just been released, which fixes this

@CommonGuy CommonGuy removed the status:waiting-for-release Implemented, waiting for next stable release label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants