Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on invalid_grant authentication #224

Closed
DominicMCN opened this issue Apr 29, 2024 · 6 comments
Closed

Retry on invalid_grant authentication #224

DominicMCN opened this issue Apr 29, 2024 · 6 comments
Labels
bug Something isn't working status:waiting-for-release Implemented, waiting for next stable release

Comments

@DominicMCN
Copy link

Describe the bug

When a refresh_token is expired, or environment changed (different credentials needed); a request authentication would fail. We would need to manually go to auth tab and click reset and update.

I vaguely remember a few versions ago, manual reset was not needed.

To Reproduce
Steps to reproduce the behavior:

  1. Authenticates with OAuth
  2. Let the token / refresh_token expires ; or change to a different environment which needs reauth
  3. Request would fail

Expected behavior

Kreya retries authentication from the beginning of the OAuth flow at least one

@DominicMCN DominicMCN added the bug Something isn't working label Apr 29, 2024
@CommonGuy
Copy link
Contributor

Which Kreya version are you using? I am unable to reproduce this with Kreya 1.14.0. Invoking an operation automatically fetches a valid token for me.

When you switch to the details tab in the authentication, does the token show as invalid/expired?

@CommonGuy CommonGuy added the status:needs-info To investigate this, more information is needed label May 1, 2024
@DominicMCN
Copy link
Author

1.14.1-beta 1

It does show as invalid-grant yea. I'll capture a screenshot when it expires again

@DominicMCN
Copy link
Author

Screenshot 2024-05-01 at 14 58 05 Screenshot 2024-05-01 at 14 58 18

@CommonGuy
Copy link
Contributor

Ah now I got it. The bug only happens when a refresh token is present, but invalid/expired. We'll fix this in the next release

@CommonGuy CommonGuy added status:doing We are working on this and removed status:needs-info To investigate this, more information is needed labels May 2, 2024
@CommonGuy CommonGuy added status:waiting-for-release Implemented, waiting for next stable release and removed status:doing We are working on this labels May 15, 2024
@CommonGuy
Copy link
Contributor

This has been fixed in the latest beta version and will be released in the next stable version

@CommonGuy
Copy link
Contributor

Kreya 1.15 has just been released, which fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:waiting-for-release Implemented, waiting for next stable release
Projects
None yet
Development

No branches or pull requests

2 participants