feat: Global dimension search in metrics view in both rill dev and cloud #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
force-pushed
the
adityahegde/global-dimension-search
branch
from
9d90695
to
551100d
Compare
AdityaHegde
force-pushed
the
adityahegde/global-dimension-search
branch
from
3c0dd7a
to
a8a9807
Compare
AdityaHegde
force-pushed
the
adityahegde/global-dimension-search
branch
from
a8a9807
to
6f6fd08
Compare
AdityaHegde
force-pushed
the
adityahegde/global-dimension-search
branch
from
f44cad1
to
4f75531
Compare
ericpgreen2
requested changes
May 20, 2024
There was a problem hiding this comment.
Overall it looks pretty good!
UXQA –
- If a search query errored, we should say so and maybe give the user the option to retry the specific query/queries. Here I received "context deadline exceeded" when searching against a Druid-backed dashboard.
- There's very poor performance when searching Druid-backed dashboards. Mind opening up a conversation with Platform to confirm the batch query approach, or if they recommend a different query pattern?
- It'd be nice to submit the form after a pause in typing. If so, subsequent typing should cancel an outstanding request.
- On an Adbids dashboard in Rill Developer, I searched for "facebook" and the search never finished searching the
Domaindimension. I see the below error in my browser console.
- When a dimension value is already set as a dashboard filter, it'd be nice if there were an indicative checkmark in the search results.
- For parity with the Enterprise application, the previous search input text should be retained when re-opening the search box.
- In Rill Developer, the search button should be to the left of the Deploy & Edit Metrics buttons.
- Nit: When there are no results yet, there shouldn't be the extra empty bottom section below the
DropdownMenuSeparator.
- Nit: I'd expect the progress bar to disappear after reaching 100%
- Nit: After using the down arrow key to focus on the first menu item, I'd like the up arrow key to re-focus on the search input.
|
As mentioned in the demo, let's add a feature flag for this so that we can iterate on the Druid performance in a follow-on PR. |
ericpgreen2
approved these changes
May 30, 2024
ericpgreen2
reviewed
May 30, 2024
package-lock.json
Outdated
There was a problem hiding this comment.
Confirming this package-lock.json modification is intended? I'm not seeing any package.json changes in this PR.
There was a problem hiding this comment.
Nope. Will revert
|
Merging this behind a feature flag: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4882
This adds a search button at the top right corner for both rill dev and cloud.