Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMockedRequestMatcher should have MatchesAsync #129

Open
pengweiqhca opened this issue Nov 6, 2023 · 2 comments
Open

IMockedRequestMatcher should have MatchesAsync #129

pengweiqhca opened this issue Nov 6, 2023 · 2 comments

Comments

@pengweiqhca
Copy link

Current, Matches is a synchronized method, there is a situation where asynchronous method are invoked synchronously.
@richardszalay
Copy link
Owner

Hi, is this hypothetical or do you have a repro where blocking on an async call within a test environment (where streams typically originate from in-memory sources) causes a deadlock?

@pengweiqhca
Copy link
Author

pengweiqhca commented Nov 7, 2023 •
edited

No deadlock, but have a hidden danger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richardszalay @pengweiqhca