-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why does Engine::eval_file_with_scope use PathBuf instead of Path? #692
Comments
Well, for historical reasons... The API is fixed so I can't easily change it to It probably should be changed to a generic |
Thanks for the quick response, I hope these changes will come someday. And... Can I contribute to this? |
Of course. Your contributions are welcome. Actually very few people use the file API (I guess) so it may actually not be very risky to change... But of course being as compatible as possible is best. |
I opened the pull request with these changes |
Why is the file path passed to
Engine::eval_file_with_scope
asPathBuf
instead ofPath
? I'm a little surprised by this decision, because it can provoke an extra allocation.The text was updated successfully, but these errors were encountered: