Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Combobox component #63

Open
rgossiaux opened this issue Feb 23, 2022 · 5 comments · May be fixed by #126
Open

Port Combobox component #63

rgossiaux opened this issue Feb 23, 2022 · 5 comments · May be fixed by #126

Comments

@rgossiaux
Copy link
Owner

Headless UI released a new combobox component a few days ago. This is a placeholder issue to track porting this component.

I estimate it'll be done in a few weeks. Before I do this, I want to ship the documentation site (which is almost ready) and make a few other technical improvements.

@gplancke
Copy link

gplancke commented May 2, 2022

Hello @rgossiaux !

First, Thank you a ton for this work, this is really awesome and I would probably not have been able to complete my projects without you !

I'd really like being able to put my custom implementation of a combobox out the window though and rely on a more battle tested solution.
Are you in the process of doing the port ? If not, I might have some time next week to give a PR a try.

Anyway, thanks again !

@rgossiaux
Copy link
Owner Author

Thanks for the comment @gplancke ! Wow, didn't realize that this issue had attracted so many reactions 😄

I've been busy with real life for the last month or two and didn't have much time to work on this project--plus I intentionally wanted to take a break from it as I spent a ton of time on it from December through February or so & that wasn't sustainable for an open source project that's never going to pay my bills. So that's why even though I initially thought this would be done some time in March, it hasn't been released yet--hope you can understand.

I'm hoping to gradually start spending a little more time on the project in the coming weeks and this one is near the top of the priority list. At the moment there are a few breaking changes I want to make first (namely #47 and #57) but they aren't too complicated (the time-consuming part will just be changing all the tests & setting up versioned documentation) and after that I will begin adding some new functionality to the library (this issue and some other enhancements that have been released in Tailwind's library).

I think the best way for anyone to help out here is to help with some of the testing work described in #47. It's not particularly glamorous but it needs to be done. I would discourage you from making a PR for this combobox issue specifically because for something this central I'd like to do it myself (for better consistency with the rest of the library; better ability to guarantee quality; better familiarity with the code as I'll be maintaining it, etc).

@gplancke
Copy link

gplancke commented May 7, 2022

Hi @rgossiaux !

Wow, didn't realize that this issue had attracted so many reactions 😄

Well no doubt, I think we all grew tired of battling with customising existing alternative combobox libraries (or making our own)... Headless/Renderless components are really a breath of fresh air in that regards.

I've been busy with real life for the last month or two and didn't have much time to work on this project--plus I intentionally wanted to take a break from it as I spent a ton of time on it from December through February or so & that wasn't sustainable for an open source project that's never going to pay my bills. So that's why even though I initially thought this would be done some time in March, it hasn't been released yet--hope you can understand

I figured :) I perfectly understand of course, and I renew my thanks for all this work ! On a side note, maybe you could consider opening sponsorship for this project (I don't know your opinions about that, and I am not saying you should, but I know I would gladly give)

I think the best way for anyone to help out here is to help with some of the testing work described in #47. It's not particularly glamorous but it needs to be done. I would discourage you from making a PR for this combobox issue specifically because for something this central I'd like to do it myself (for better consistency with the rest of the library; better ability to guarantee quality; better familiarity with the code as I'll be maintaining it, etc).

I agree about you being the best person to handle this. I started fiddling around in a fork, and while I might come up with something working, I won't guarantee it would be up to the current library standard (I have to say, you put the bar really high, everything is really well done, and I find your code to be even more readable than the original tailwind lib - which is already really nicely engineered)
I'll have a look at #47 and see if I can help there, anything which could lighten your workload :) No making any promises as, like you, I am quite busy with real life right now, but will definitely try !

Best of luck to you and hopefully see you again in another issue !
Cheers,

@janikschoenfelder
Copy link

Hi @rgossiaux, thank you also for your impressive work so far!!

Seems like private life still takes your time, hope you're doing good.

I'm curious if you plan further development on this port and especially with this component. Or do you know about any movement from HeadlessUI side regarding Svelte support?

@NoelOConnell NoelOConnell linked a pull request Oct 12, 2022 that will close this issue
@sserdyuk
Copy link

Hi @rgossiaux , thank you for starting this package. It has been instrumental for us. You started a great project, and, perhaps, it is time to let other people to the core team? It would help to lessen your load and keep the project alive. @NoelOConnect is very active in the bug reports and made a few pull requests. Would you two please cooperate in interest of the greater community? Thank you and I hope all is well with you.

@rgossiaux rgossiaux pinned this issue Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants