Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Svelte 4 #152

Open
silenceofthewans opened this issue Jun 28, 2023 · 13 comments
Open

Support Svelte 4 #152

silenceofthewans opened this issue Jun 28, 2023 · 13 comments

Comments

@silenceofthewans
Copy link

Changelog:
https://github.com/sveltejs/svelte/blob/master/packages/svelte/CHANGELOG.md

@rgossiaux
Copy link
Owner

Yes, I'll be hoping to release official Svelte 4 compatibility soon, but I haven't tested it out much yet because some of my dependencies need to be upgraded.

In the meantime, please let me know if anyone has been using the library with Svelte 4 successfully or unsuccessfully. From what I've seen it should be fine, but this library's internals do some pretty sophisticated things in a few places, which is why I haven't just bumped the peerDependencies without doing some testing first.

@silenceofthewans
Copy link
Author

I've been using Menu and Listbox in my app and they seem to be working fine can't say much for other components.

@Robin-w151
Copy link

I've been using the Popover component and everything is running smooth so far.

@AyeRlS
Copy link

AyeRlS commented Jul 1, 2023

It seems to work well, no issue so far

@JeremyDarbellay
Copy link

I've been using the Dialog component, no troubles atm.

@MaximumMaxxx
Copy link

MaximumMaxxx commented Jul 5, 2023

Switch component works fine

@vfrunza
Copy link

vfrunza commented Jul 18, 2023

Listbox has been working fine for me too.

@MaximumMaxxx
Copy link

Has anyone found a workaround for the peer dependencies not being aligned to use while this issue sits in limbo?

@rgossiaux
Copy link
Owner

@MaximumMaxxx You should be able to just ignore the warning. I've been traveling lately but I plan on releasing an update to bump the peerDependencies in a week or two.

@padidas
Copy link

padidas commented Aug 1, 2023

In case anyone is wondering how to overwrite the peer dependencies - this worked for me:

"devDependencies": {
  ...
  "@rgossiaux/svelte-headlessui": "^2.0.0",
  "svelte": "^4.1.2",
  ...
},
"overrides": {
  "@rgossiaux/svelte-headlessui": {
    "svelte": "$svelte"
  }
}

@zach-hopkins
Copy link

In case anyone is wondering how to overwrite the peer dependencies - this worked for me:

"devDependencies": {
  ...
  "@rgossiaux/svelte-headlessui": "^2.0.0",
  "svelte": "^4.1.2",
  ...
},
"overrides": {
  "@rgossiaux/svelte-headlessui": {
    "svelte": "$svelte"
  }
}

Thank you for this.

Have been using in production for two weeks with no issues @rgossiaux

@bradyisom
Copy link

I'm using with Svelte v4 and it looks like the open prop in Disclosure is not working.

@adminy
Copy link

adminy commented Mar 21, 2024

Svelte 5 support? Unfortunately it's not backwards compatible and it's not as simple as version bump. Any plans to support svelte 5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests