-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
organizing imports #427
Comments
An |
Thank you!! If there's anything i can help you with, i'd gladly work with you |
I try to create a script to generate Sorry I don't have time to resolve/rename them. So I will pending this task currently.
|
Thank you for your hard work 👍 I've also checked the error and as you mentioned, it seems that there are files with the same class names despite being in different modules. However, in addition to just organizing imports, ensuring unique class names across modules seems necessary? |
From the first post import RoundRectangle from 'phaser3-rex-plugins/plugins/roundrectangle.js';
import YoutubePlayer from 'phaser3-rex-plugins/plugins/youtubeplayer.js';
import ContainerLite from 'phaser3-rex-plugins/plugins/containerlite';
import {TextEdit, Edit} from 'phaser3-rex-plugins/plugins/textedit.js'; It seems that most of classes can be found in ui-components.js, except YoutubePlayer. |
Oh, import { ScrollablePanel, FixWidthSizer, Label, RoundRectangle } from 'phaser3-rex-plugins/templates/ui/ui-components.js'; But as you mentioned, Making two integrated modules (rexUI, plugins) might looks redundant and confusing (duplicated import ex. Maybe need couple of guides to the developers about using |
|
Sure! I understand what you meant. Take your time! |
Description
How about adding a
index.ts
which includes all plugin files so that the import lines look clean?As-Is
To-Be
To look like this, i think we need to remove all the
d.ts
file of each component and make a intergratedindex.ts
.Also have to change
export default
toexport
needs to be done
If it looks good, i'm willing to make a contribution.
BTW, thank you for making this cool lib 👍
The text was updated successfully, but these errors were encountered: