losoto now part of KERN

[gijzelaerr]

more info about KERN:
http://kernsuite.info

To quickly install losoto on Ubuntu 16.04 (LTS):

$ sudo apt-get install software-properties-common
$ sudo add-apt-repository -s ppa:kernsuite/kern-2
$ sudo apt-add-repository multiverse
$ sudo apt-get update
$ sudo apt-get install losoto

metadata files can be found here:
https://github.com/kernsuite-debian/losoto

[mooneyse]

Hi,

In KERN, the script losoto/losoto/_importer.py is just called losoto/losoto/importer.py. I was running a Python script which had from losoto._importer import create_h5parm but I had to change it to from losoto.importer import create_h5parm. From the GitHub file history, this _importer.py was renamed on 05 December 2017, after it became available on KERN. Is it possible to update this file name on KERN?

[gijzelaerr]

sure! Happy you are using it. The right way is to report an issue on the kernsuite issue tracker:

https://github.com/kernsuite/packaging/issues

[gijzelaerr]

just did for you :)

[mooneyse]

Thanks, I'll report on the KERN suite GitHub in future. And thank you for the quick fix!

[gijzelaerr]

Ok now I see what the problem is. So actually this is a bug in the 1.0.1 release right? Why don't you make a 1.0.2 release based on 1.0.1 and apply that change? you can easily make a branch from the 1.0.1 commit, apply the fix and then make a 1.0.2 release from that branch? Then you can make sure everything works properly.

[revoltek]

I wasn't planning to maintain the 1.0 anymore, we largely restructure the code for the 2.0 (which is now released) and we wanted to maintain only that version (consider that this work is done only in my little free time)

[gijzelaerr]

same here, I'm not getting paid to maintain your code.

[revoltek]

sure, I wan't saying that you've to do it :) I was wondering if the problem could be solved by incorporating the 2.0 version in the kern suite instead of using a 1.0.x

[gijzelaerr]

KERN-3 only receives bugfixes, but sure we can add 2.0 to KERN-4 (now KERN-dev)

[nudomarinero]

I think there is some legacy code using Losoto 1 that uses the importer.py (whithout the "_"). Actually I am using one of those codes. If Losoto 1 is to be patched, I would just create an additional file _importer.py that just imports everything from importer.py to keep both versions of the file working. Does this make sense?

[mooneyse]

There are some other differences I think. When I'm running this script, it tries to call the getSoltab function (using from losoto.h5parm import h5parm with the KERN version) and it fails. It works when I link to the 2.0 GitHub version though.

[gijzelaerr]

ok well let me know if you come to a solution and have made a release of the fix, then i update the package.

[revoltek]

Losoto 2.0 and 1.0 are very different, and there's no backward compatibility for importing operations from python or the parset keywords. This was necessary as losoto 1.0 has been developed adding piece to piece without a big picture in mind, losoto 2.0 tries to harmonize everything.

[gijzelaerr]

just to add, losoto 2.0 will become part of KERN-4 (now dev)