-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
German Language Support #125
Comments
Hi Joe! When you add patterns in For Q2, maybe free make a PR with the data, then I can advise a test for that? Though, what you have for french in retext-profanities, is very similar to what I’d suggest. You don’t have to be exhaustive, a couple of tests should be enough! |
Initial checklist
Problem
I am supporting a colleague's project to build a browser plugin for encouraging gender-neutral language in German. I was really happy to find
retext-equality
and think it could be a brilliant base for some of the functionality.I want to support my colleague in adding German language to
retext-equality
. (Some of the contributors won't be familiar with programming and I don't speak German.) I have seen that there are similar approaches to supportretext-profanities
(get-alex/alex#212). I also found a relevant issue here which ended with @wooorm refactoring the code to support multiple languages (#59). This is great!I've started following the suggestions in #59 (comment) by adding a couple of basic rules and I am now trying to add the tests. I have a few questions about the best way to do this as it will form the template for both German and adding other languages.
Solution
Should I follow the approach taken in
retext-profanities
and exportretextEqualityDe
fromde.js
?How should I set up tests?
I'm not super familiar with writing tests in Javascript but it looks simple enough. That said, I would like some support in creating a template for testing non-English language patterns in
retext-equality
.The main reference I have found is that
retext-profanities
has the following test (https://github.com/retextjs/retext-profanities/blob/main/test.js#L35):This only runs for one test, whereas in
retext-equality
there are many tests for English.Could someone give me an example of how a good template for the non-English tests would look?
Alternatives
I could intuitively push forward or not put in tests but I don't think either are good ideas!
The text was updated successfully, but these errors were encountered: