-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not able to use next-intl
's createTranslator with Tailwind component
#1244
Comments
next-intl
's createTranslator with Tailwind component
Same error with |
@antoinerousseau Is it the same exact error or just a similar error? |
(working with @antoinerousseau here 👋 ) |
After digging around a lot this should be fixed by #1124 which I have tested myself. Not sure how this is caused but some of the polyfills we have currently on tailwind are causing this—something to do with tslib. @ababol @antoinerousseau lmk if you are blocked by not using intl here cuz I can make a patch for you from #1124. Also, the error overlay is just not helping here so I'm opening up a new PR #1264 to improve it to show something more accurate. Here's the actual stack trace: |
Thanks @gabrielmfern! But no worries it's not urgent, meanwhile we developed our own minimalist preview that uses RSC and next-intl :) |
Thanks @gabrielmfern!
#666 (comment) (see details) It works perfectly in dev mode but not when we actually build the web app (next build / next start). |
Nope, that's something else, someone also had this #1112 |
@gabrielmfern ist there any possibility to get a patch for this so we can test this? we also seem to run into this exact error. |
@mmachatschek Sure, no problem. And here is a quick guide of how to apply it if you have any trouble lmk if it works out for you |
@gabrielmfern the patch didn't solve the issue for me (we are not using the |
@gabrielmfern patch failed for me also. Using |
@mmachatschek @justinnais Could one of you give a reproduction for this? Seems like your issue is something else here 🤔 |
Also, were you not able to apply the patch or did it apply successfully but still fail when running? I tried applying it myself and wasn't able to, so I've updated it and it should apply properly now |
Failed to apply. I'll retry the patch. What's the best way to provide you a repro @gabrielmfern? |
@gabrielmfern for me the patch applied correctly with pnpm I'll provide a repro asap |
@gabrielmfern this is the reproduction repo: https://github.com/mmachatschek/react-email-repro-issue-1244 check the |
@mmachatschek Thank you so much for providing the reproduction here, I applied the patch I sent before and the error wasn't gone. I then realized I sent the wrong patch here, I properly got the diff and swapped the patch with the proper one and it seems to be working fine even with your repro. Also from what I saw you had an issue applying the patch @justinnais; if you were using If you used |
@gabrielmfern I can confirm that the provided patch is working now 👍 |
When trying to apply your patch, I get the following error:
Any idea? |
@gijsmin You need to apply the patch to |
what's plan of this PR |
a specific to patch-package patch would be appreciated since I cannot apply the patch even after modifying it, probably im doing something wrong but can't tell what. |
Describe the Bug
i have this template :
in preview mode i have this error :
when i remove Tailwind it s work correctly :
Which package is affected (leave empty if unsure)
No response
Link to the code that reproduces this issue
https://gitlab.com/robin.louarn/programme-tz-2023
To Reproduce
nvm use
pnpm install
pnpm email:dev
Expected Behavior
see a preview of email
What's your node version? (if relevant)
20.11.0
The text was updated successfully, but these errors were encountered: