Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback fonts are not correct #1037

Open
jakeleventhal opened this issue Nov 18, 2023 · 2 comments
Open

Fallback fonts are not correct #1037

jakeleventhal opened this issue Nov 18, 2023 · 2 comments

Comments

@jakeleventhal
Copy link

Describe the Bug

https://jsfiddle.net/oyec3awm/11/ this shows the correct fallback font families. The prop type is incorrect currently.

Which package is affected (leave empty if unsure)

@react-email/components, @react-email/font

Link to the code that reproduces this issue

https://jsfiddle.net/oyec3awm/11/

To Reproduce

See fiddle

Expected Behavior

Updated prop types

What's your node version? (if relevant)

No response

@gabrielmfern
Copy link
Collaborator

Can you please elaborate a bit more?

@gabrielmfern gabrielmfern added the Resolution: Needs More Information More information is needed on this issue label Jan 27, 2024
@jakeleventhal
Copy link
Author

The jsfiddle i provided shows the proper fallback fonts that are supported by most clients (i.e. gmail)

The proptypes are incorrect in this package

@gabrielmfern gabrielmfern removed the Resolution: Needs More Information More information is needed on this issue label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants