Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn should fail if spawning a viewer that is incompatible #6430

Open
jleibs opened this issue May 24, 2024 · 0 comments
Open

Spawn should fail if spawning a viewer that is incompatible #6430

jleibs opened this issue May 24, 2024 · 0 comments
Labels
🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team

Comments

@jleibs
Copy link
Member

jleibs commented May 24, 2024

If using C++/Rust, it's possible for the SDK to spawn an old viewer that can't handle the new protocol.

This results in the viewer rejecting the incoming connection with a warning:

[2024-05-23T21:46:04Z WARN re_sdk_comms::server] Closing connection to client at 127.0.0.1:53540: SDK client is using a newer protocol version (1) than the SDK server (0)

Although spawn generates an error message such as

    ⚠ The version of the Rerun Viewer available on your PATH does not match the version of your Rerun SDK ⚠

    Rerun does not make any kind of backwards/forwards compatibility guarantee yet: this can lead to (subtle) bugs.

    Rerun Viewer: v0.15.0 (executable: "rerun")
    Rerun SDK: v0.16.0

it doesn't cause the spawning application to terminate. This means the warning message can be lost and the place where the failure happens is less obvious.

At a minimum we should have spawn return an error code to the user so they can determine whether to fail out or keep running.

@jleibs jleibs added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team
Projects
None yet
Development

No branches or pull requests

1 participant