Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate archetype field info (opt-in for a single type so far) and use it in blueprint property ui #6413

Merged
merged 7 commits into from
May 23, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 22, 2024

What

This creates an tight nit & generic coupling from our type definitions to the ui! This is to be used in all blueprint properties, so far used on PlotLegend only.
image

Drawbacks:

  • lower snake case because that's what our fields look like - we could change that easily but there's some value to that because that's what all SDKs use as field names. Very much open for discussion!
  • some parts of the doc strings might be weird outside of the context of the ui, but I can live with that

Future stuff:

  • we could very very easily now also add reference doc links in there via some linking mechanism (viewer could choose depending on preference or source sdk)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself ⛴ release Related to shipping or publishing codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 22, 2024
@Wumpf
Copy link
Member Author

Wumpf commented May 23, 2024

Improved!
image

@emilk emilk self-requested a review May 23, 2024 08:28
Copy link
Contributor

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Wumpf Wumpf force-pushed the andreas/generic-property-field-names-and-docs branch from 4dd9f3b to f50a8e1 Compare May 23, 2024 10:51
@Wumpf Wumpf merged commit 2c20040 into main May 23, 2024
34 of 35 checks passed
@Wumpf Wumpf deleted the andreas/generic-property-field-names-and-docs branch May 23, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself ⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants