Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on suggestion does not select it #6143

Closed
roym899 opened this issue Apr 27, 2024 · 3 comments · Fixed by #6200
Closed

Clicking on suggestion does not select it #6143

roym899 opened this issue Apr 27, 2024 · 3 comments · Fixed by #6200
Assignees
@emilk
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface user-request This is a pressing issue for one of our users
Milestone
0.16

Comments

@roym899
Copy link
Collaborator

roym899 commented Apr 27, 2024 •
edited

Describe the bug
Selecting a space origin from the suggestions does not select it when clicking. Only the list of suggestions is closed.

Selecting via arrowkeys + enter works.

Video

suggestion.mp4

(ignore the flickering)

Desktop (please complete the following information):

  • Ubuntu 22.04

Rerun version

rerun_py 0.15.0 [rustc 1.74.0 (79e9716c9 2023-11-13), LLVM 17.0.4] x86_64-unknown-linux-gnu release-0.15.0 bc8bcd0, built 2024-04-09T14:34:04Z
@roym899 roym899 added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team labels Apr 27, 2024
@Wumpf Wumpf added ui concerns graphical user interface 😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less user-request This is a pressing issue for one of our users and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Apr 27, 2024
@Wumpf
Copy link
Member

Wumpf commented Apr 27, 2024

gave this a user-request just to priotize it - this just looks so insanely annoying Oo

@abey79
Copy link
Contributor

abey79 commented Apr 30, 2024

Spent a bit of time tracking this one down but haven't yet found the problem.

This worked in 0.14.1 and broke in 0.15.0

The reponse from space_view_space_origin_ui.rs line 200 never returns true with clicked(), even when the list item is indeed clicked in the UI. This is probably due to the fact that the list items are in a ReUi::list_item_popup(), which might have been broken by egui's new widget logic.

cc @emilk

@abey79 abey79 added this to the 0.16 milestone May 1, 2024
@emilk emilk self-assigned this May 2, 2024
@emilk
Copy link
Member

emilk commented May 2, 2024

If you click slowly you'll notice that the popup closes on the press, not the release (and clicks are registered on release).
So the popup is closing before the click is registered.
The reason is that the text edit looses focus when the user presses somewhere else, and that switches us to SpaceOriginEditState::NotEditing, and then the code path for showing the popup ui isn't run.

@emilk emilk mentioned this issue May 2, 2024
Merged
5 tasks
emilk added a commit that referenced this issue May 2, 2024
@emilk
Fix not being able to click suggestions in space origin selection dro…
ffb935c 
…pdown (#6200)

### What
* Closes #6143

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6200?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6200?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6200)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface user-request This is a pressing issue for one of our users
Projects
None yet
Milestone
0.16
Development

Successfully merging a pull request may close this issue.

Fix not being able to click suggestions in space origin selection dropdown rerun-io/rerun
4 participants
@emilk @Wumpf @roym899 @abey79