Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to disable the welcome screen from code #6140

Open
jleibs opened this issue Apr 26, 2024 · 2 comments
Open

Add a way to disable the welcome screen from code #6140

jleibs opened this issue Apr 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself user-request This is a pressing issue for one of our users
Milestone

Comments

@jleibs
Copy link
Member

jleibs commented Apr 26, 2024

While the welcome screen makes sense for users that are primary users of Rerun, it can be confusing to "secondary users", when Rerun is used as part of a visualizer spawned by another application.

We already have a menu option to disable this, but there's no way to set it from code.

@jleibs jleibs added enhancement New feature or request 📺 re_viewer affects re_viewer itself user-request This is a pressing issue for one of our users labels Apr 26, 2024
@jleibs jleibs changed the title Add a way to disable the welcome screen. Add a way to disable the welcome screen from code Apr 26, 2024
@jleibs jleibs added this to the 0.16 milestone May 3, 2024
@emilk
Copy link
Member

emilk commented May 6, 2024

You want to set this as an init argument, or as a blueprint option, or what?

@jleibs
Copy link
Member Author

jleibs commented May 6, 2024

Maybe even just an argument to spawn?

Doing it from blueprint would be nice too, but introduces some weird edge-cases when multiple blueprints conflict on what to do.

Would also like to be able to do it from Gradio, so a url-param would be nice there as well.

@emilk emilk added the 🏎️ Quick Issue Can be fixed in a few hours or less label May 6, 2024
@jleibs jleibs self-assigned this May 7, 2024
jleibs added a commit that referenced this issue May 10, 2024
### What
- Partially addresses: #6140

We still need to also tackle
#6263 since the place-holder UI
isn't great.

![image](https://github.com/rerun-io/rerun/assets/3312232/736a42fb-a29e-48e2-8316-9dc790f1e3ad)

### Details
Handling this via blueprint is awkward since the welcome screen
presentation happens without respect to any given blueprint, or in cases
when all the recordings and their blueprints have been closed.

I decided adding this as a spawn option makes the most sense, since this
is the context where someone knows how they are embedding Rerun in
another application.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6262?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6262?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6262)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself user-request This is a pressing issue for one of our users
Projects
None yet
Development

No branches or pull requests

2 participants