Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step to next visible data #6139

Open
kpreid opened this issue Apr 26, 2024 · 0 comments
Open

Step to next visible data #6139

kpreid opened this issue Apr 26, 2024 · 0 comments
Labels
enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team

Comments

@kpreid
Copy link
Contributor

kpreid commented Apr 26, 2024

The arrow buttons / keys are currently described as:

  • Step back to previous time with any new data (left arrow)
  • Step forwards to next time with any new data (right arrow)

I think it would be more useful if they stepped to the next/previous visible change in the data — that is, they should take into account only data which is displayed by the current set of visible space views.


I took a look at implementing this myself, but couldn't figure out what pieces to put together to achieve it. re_viewer::App::run_time_control_command() would need to use the blueprint to make a suitable query to the data store to pass enough information to the TimeControl.

@kpreid kpreid added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Apr 26, 2024
@kpreid kpreid changed the title Step to next *visible* data Step to next visible data Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team
Projects
None yet
Development

No branches or pull requests

1 participant