Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity path with combined Transform3D + Pinhole as origin makes it impossible to visualize any parents #6138

Open
roym899 opened this issue Apr 26, 2024 · 2 comments
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less
Milestone

Comments

@roym899
Copy link
Collaborator

roym899 commented Apr 26, 2024

Describe the bug
When combining a 3D transform and a pinhole transform on the same entity path and setting this path as the origin of a 3D view, no parents / siblings can be visualized in such a view anymore.

This makes it impossible to let the view follow a moving camera, for example.

To Reproduce

import rerun as rr
import numpy as np

rr.init("merged pinhole + transform3d", spawn=True)

rr.log("", rr.Points3D(np.random.rand(100, 3), colors=(255,0,0)))

rr.log("camera", rr.Transform3D(translation=(0, 5, 0)))
rr.log("camera", rr.Pinhole(resolution=(500, 500), principal_point=(250, 250), focal_length=(500, 500)))

Setting camera as the origin, the points cannot be visualized anymore.

Expected behavior
I'd expect the origin to be at the origin of the frustum, but other entities still to be addable.

Rerun version

rerun_py 0.15.0 [rustc 1.74.0 (79e9716c9 2023-11-13), LLVM 17.0.4] x86_64-unknown-linux-gnu release-0.15.0 bc8bcd0, built 2024-04-09T14:34:04Z
@roym899 roym899 added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team labels Apr 26, 2024
@Wumpf
Copy link
Member

Wumpf commented Apr 27, 2024

siblings & parents should work fine if you add them to the contents of the space view - default contents are everything under the origin, but you can also set it to e.g. /** and then it should work fine
(if it doesn't that is indeed a bug)

EDIT: guess that's what you're literally saying by other entities are not addable

@Wumpf Wumpf added 🏎️ Quick Issue Can be fixed in a few hours or less and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Apr 27, 2024
@Wumpf Wumpf added this to the Triage milestone Apr 27, 2024
@roym899
Copy link
Collaborator Author

roym899 commented Apr 27, 2024

Yes, I don't think it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Development

No branches or pull requests

2 participants