Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to upload .rrd for easy sharing #6052

Closed
emilk opened this issue Apr 20, 2024 · 4 comments · Fixed by #6111
Closed

Add script to upload .rrd for easy sharing #6052

emilk opened this issue Apr 20, 2024 · 4 comments · Fixed by #6111
Assignees
@emilk @jleibs
Labels
🧑‍💻 dev experience developer experience (excluding CI) examples Issues relating to the Rerun examples 🏎️ Quick Issue Can be fixed in a few hours or less

Comments

@emilk
Copy link
Member

emilk commented Apr 20, 2024 •
edited by teh-cmc

Something like:

> pixi run upload-rrd --version 0.15.1 my_rrd.rrd
Uploaded to https://some-gcs-bucket/my_rrd.rrd
View it with https://app.rerun.io/version/0.15.1?url=https://some-gcs-bucket/my_rrd.rrd

This will be very useful when sharing examples.

Being able to read the version string from the .rrd would be nice, e.g. using rerun print
@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) examples Issues relating to the Rerun examples 🏎️ Quick Issue Can be fixed in a few hours or less labels Apr 20, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Apr 23, 2024 •
edited

Actually I just checked and rerun print recording.rrd prints everything we know about the recording... except the Rerun version 🤦

Should fix that as well.

@emilk emilk self-assigned this Apr 25, 2024
@emilk emilk mentioned this issue Apr 25, 2024
Merged
5 tasks
@emilk emilk assigned jleibs and unassigned emilk Apr 26, 2024
@emilk
Copy link
Member Author

emilk commented Apr 29, 2024

There is a draft in #6111 but needs some GCS magic in order to set up a HTTP endpoint for the new GCS bucket

@jleibs
Copy link
Member

jleibs commented Apr 29, 2024

static.rerun.io now has a url matcher that forwards /rrd/* to the rrd bucket.

See:
https://static.rerun.io/rrd/0.15.1/rgbd_3f2ebd882270ce75cec25022152f468194c8c4ef.rrd

@emilk
Copy link
Member Author

emilk commented Apr 30, 2024

Next problem is CORS:

Access to fetch at 'https://static.rerun.io/rrd/0.15.1/rgbd_3f2ebd882270ce75cec25022152f468194c8c4ef.rrd' from origin 'https://www.rerun.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

emilk added a commit that referenced this issue Apr 30, 2024
@emilk @teh-cmc
Add script to upload an .rrd file (#6111)
9c42ba7 
### What
* Closes #6052

Example:

```
pixi run upload-rrd ../rgbd.rrd --version 0.15.1
```

Result:
https://www.rerun.io/viewer/version/0.15.1?url=https%3A%2F%2Fstatic.rerun.io%2Frrd%2F0.15.1%2Frgbd_3f2ebd882270ce75cec25022152f468194c8c4ef.rrd

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6111?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6111?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6111)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

---------

Co-authored-by: Clement Rey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

@jleibs jleibs

Labels
🧑‍💻 dev experience developer experience (excluding CI) examples Issues relating to the Rerun examples 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add script to upload an .rrd file rerun-io/rerun
3 participants
@emilk @teh-cmc @jleibs