Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static components doesn't roundtrip when saved to .rrd file #6094

Closed
emilk opened this issue Apr 24, 2024 · 4 comments · Fixed by #6167
Closed

static components doesn't roundtrip when saved to .rrd file #6094

emilk opened this issue Apr 24, 2024 · 4 comments · Fixed by #6167
Assignees
@teh-cmc
Labels
🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself 🦟 regression A thing that used to work in an earlier release

Comments

@emilk
Copy link
Member

emilk commented Apr 24, 2024

Repo: load "detect and track objects example", and looks at the streams view:

Screenshot 2024-04-24 at 11 42 25

Save it to disk, close rerun, and load the saved .rrd. Look again:

Screenshot 2024-04-24 at 11 43 11
@emilk emilk added 🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself 🦟 regression A thing that used to work in an earlier release labels Apr 24, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Apr 24, 2024

Oh I don't think we even have a roundtrip test for the save path on the viewer-side 🤦 (as opposed to the save path on the SDK side).

@teh-cmc teh-cmc self-assigned this Apr 24, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Apr 30, 2024

Oh I don't think we even have a roundtrip test for the save path on the viewer-side 🤦 (as opposed to the save path on the SDK side).

Nevermind, we have a pretty extensive test suite for this in fact... what's going on here 🤔

@teh-cmc
Copy link
Member

teh-cmc commented Apr 30, 2024

I actually cannot repro this. I tried:

  • Saving entire timeline, 0.15.1
  • Saving time selection, 0.15.1
  • Saving entire timeline, main
  • Saving time selection, main

@teh-cmc teh-cmc mentioned this issue Apr 30, 2024
Merged
5 tasks
@emilk
Copy link
Member Author

emilk commented Apr 30, 2024

Then let's close this

@emilk emilk closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2024
teh-cmc added a commit that referenced this issue Apr 30, 2024
@teh-cmc
Add some static data to the store dump test suite (#6167)
c672f98 
I cannot reproduce #6094, see
#6094 (comment):
> I actually cannot repro this. I tried:
> - Saving entire timeline, `0.15.1`
> - Saving time selection, `0.15.1`
> - Saving entire timeline, `main`
> - Saving time selection, `main`

For now the best I can think of is to add some static data to the test
suite and call it a day...

~Marking as do not merge until the situation is clarified.~

- Closes #6094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add some static data to the store dump test suite rerun-io/rerun
2 participants
@emilk @teh-cmc