Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint modifications are not saved when closing a recording #5854

Closed
Wumpf opened this issue Apr 8, 2024 · 1 comment · May be fixed by #5849
Closed

Blueprint modifications are not saved when closing a recording #5854

Wumpf opened this issue Apr 8, 2024 · 1 comment · May be fixed by #5849
Assignees
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working
Milestone

Comments

@Wumpf
Copy link
Member

Wumpf commented Apr 8, 2024

Repro steps:

  • Run an example that defines a blueprint (e.g. pixi run python ./examples/python/rgbd/main.py)
  • do some blueprint modification in the ui
  • close the recording (not the viewer!)
  • run the example again
    • observe that your blueprint modifications are not there!

As video:
https://drive.google.com/file/d/1Y18hwNfDofu533SthTQT7_CF8sRHP1iv/view?usp=sharing

@Wumpf Wumpf added 🪳 bug Something isn't working 🟦 blueprint The data that defines our UI labels Apr 8, 2024
@emilk emilk self-assigned this Apr 8, 2024
@emilk emilk added this to the 0.15.1 milestone Apr 9, 2024
Wumpf pushed a commit that referenced this issue Apr 9, 2024
### What
* Closes #5854


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[rerun.io/viewer](https://rerun.io/viewer/pr/5868)
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5868?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5868?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5868)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@emilk
Copy link
Member

emilk commented Apr 9, 2024

Closed by #5868

@emilk emilk closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants