Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double exception logging causes double stack trace #179

Open
gconklin opened this issue Aug 25, 2022 · 0 comments
Open

Double exception logging causes double stack trace #179

gconklin opened this issue Aug 25, 2022 · 0 comments

Comments

@gconklin
Copy link

https://github.com/requests/requests-kerberos/blob/master/requests_kerberos/kerberos_.py#L232
This bit of error handling is logging the stack trace twice.

Perhaps one should be log.error() - or maybe both should be log.error() and leave it up to the caller to log the stack trace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gconklin