Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated report is blank #2202

Closed
damithc opened this issue May 13, 2024 · 5 comments · Fixed by #2203
Closed

Generated report is blank #2202

damithc opened this issue May 13, 2024 · 5 comments · Fixed by #2203

Comments

@damithc
Copy link
Collaborator

damithc commented May 13, 2024

Example https://nus-tic2002-ay2324s2.github.io/ip-dashboard/

@ckcherry23
Copy link
Member

@ckcherry23
Copy link
Member

ckcherry23 commented May 13, 2024

Based on some initial investigation, seems like the issue might be with GitHub pages deploying sites built with Vite.

Locally, the RepoSense build and frontend build work correctly. This can also be seen in the CI run log output. However, deploying sites built with Vite on GitHub Pages requires configuring the base in vite.config.js as the subdirectory (or repository name) where the report is deployed (eg. /ip-dashboard/)

However, since RepoSense reports will be deployed on multiple GitHub Pages URLs, this will require introducing a new environment variable to specify the base, which is not ideal. We need to verify if this is the actual reason and decide if we just revert the PR or introduce the env variable.

The issue may also be related to #2194 instead, as many of our Surge deployments are also not working (even before the migration to Vite).

@ckcherry23
Copy link
Member

ckcherry23 commented May 14, 2024

I have verified that the issue is due to the Vite config requirements for GitHub pages. Specifying /ip-dashboard/ as the base in the Vite config allows GitHub to find the required files to display the static site, as can be seen here https://ckcherry23.github.io/ip-dashboard/.

For now, I have created a PR to revert back to Vue CLI. Considering that Vue CLI is in maintenance mode and has security issues with dependencies, we can consider switching back to Vite later with a better solution.

@damithc
Copy link
Collaborator Author

damithc commented May 14, 2024

Thanks for the investigation @ckcherry23

@damithc
Copy link
Collaborator Author

damithc commented May 14, 2024

https://nus-tic2002-ay2324s2.github.io/ip-dashboard/ works now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed/Completed
Development

Successfully merging a pull request may close this issue.

2 participants