Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Changes upon refresh #2058

Closed
SkyBlaise99 opened this issue Oct 11, 2023 · 3 comments
Closed

URL Changes upon refresh #2058

SkyBlaise99 opened this issue Oct 11, 2023 · 3 comments
Labels

Comments

@SkyBlaise99
Copy link
Contributor

Tell us about your environment

  • RepoSense Version: Current latest 5cd529f
  • OS and Version: Windows 11
  • Web Browser and Version (if applicable): Chrome Version 118.0.5993.71 (Official Build) (64-bit)

Please include the steps to reproduce the bug.

  1. Generate a report and view it java -jar RepoSense.jar -repo https://github.com/reposense/RepoSense.git -v
  2. Click to view author's (Eugene's) contribution
  3. Input README.md into Filter by glob
  4. The current URL is http://localhost:9000/?search=&sort=groupTitle%20dsc&sortWithin=title&since=2018-05-03&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=false&tabOpen=true&tabType=authorship&zFR=false&tabAuthor=eugenepeh&tabRepo=reposense%2FRepoSense%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFilesGlob=README.md
  5. Refresh the webpage, the URL changes to http://localhost:9000/?search=&sort=groupTitle%20dsc&sortWithin=title&since=2018-05-03&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=false&tabOpen=true&tabType=authorship&zFR=false&tabAuthor=eugenepeh&tabRepo=reposense%2FRepoSense%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFilesGlob=README.md%23%2F (extra %23%2F)
  6. The search bar is now README.md#/

What was expected to happen?

The search bar should remain at README.md

What actually happened? Please include a screenshot of the output.

Before:
image

After referesh:
image

If possible, include the URL to your RepoSense report or log files (if any).

@SkyBlaise99 SkyBlaise99 changed the title URL Error URL Changes upon refresh Oct 11, 2023
@SkyBlaise99
Copy link
Contributor Author

It seems to be related to #1987 in some ways, from what I observe, %23%2F is first attached to the url, causing the search input to be different, hence returning different or no results. At this point of time, the authorshipFilesGlob param seem to disappear from the url subsequently, hence upon the 2nd refresh, the Glob filter automatically resets.

@jonasongg
Copy link
Contributor

@reposense/active-reviewers-1 This might be fixed with #2086?

@ckcherry23
Copy link
Member

Fixed by #2086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed/Completed
Development

No branches or pull requests

3 participants