From 1e76355901cd5fca71a2999e2c8cdf68bdd0988c Mon Sep 17 00:00:00 2001 From: jonasongg <120372506+jonasongg@users.noreply.github.com> Date: Fri, 19 Apr 2024 00:13:59 +0800 Subject: [PATCH] Fix lint warnings (#2182) Fix lint warnings Currently, there are various lint warnings that appear when building. This can cause confusion on what lint problem exactly is causing a build to fail. Let's fix them. --- docs/_markbind/layouts/ug-sitenav.md | 2 +- docs/about.md | 2 +- docs/ug/authorConfigSyntax.md | 2 +- docs/ug/usingReports.md | 2 +- frontend/src/components/c-summary-charts.vue | 10 ++++++---- 5 files changed, 10 insertions(+), 8 deletions(-) diff --git a/docs/_markbind/layouts/ug-sitenav.md b/docs/_markbind/layouts/ug-sitenav.md index aef7cbef49..5acddb1015 100644 --- a/docs/_markbind/layouts/ug-sitenav.md +++ b/docs/_markbind/layouts/ug-sitenav.md @@ -7,7 +7,7 @@ {name: "Appendices"}, {level: 2, name: "CLI syntax reference", link: "ug/cli.html"}, {level: 2, name: "Config files format", link: "ug/configFiles.html"}, - {level: 2, name: "Advanced syntax: `author-config.csv`", link: "ug/authorConfigSyntax.html"}, + {level: 2, name: "Advanced syntax: `author-config.csv`", link: "ug/authorConfigSyntax.html"}, {level: 2, name: "Using `@@author` tags", link: "ug/usingAuthorTags.html"}, {level: 2, name: "RepoSense with Netlify", link: "ug/withNetlify.html"}, {level: 2, name: "RepoSense with GitHub Actions", link: "ug/withGithubActions.html"}, diff --git a/docs/about.md b/docs/about.md index 2946256f1f..1f1f2668ac 100644 --- a/docs/about.md +++ b/docs/about.md @@ -30,7 +30,7 @@ Contributor [2023 January - 2024 January]
### [Gokul Rajiv](https://github.com/gok99) -**Role**: Senior Developer [2024 January - ]
+**Role**: Senior Developer [2024 January - ]
Contributor [2022 January - 2024 January]
diff --git a/docs/ug/authorConfigSyntax.md b/docs/ug/authorConfigSyntax.md index c498f5e276..999820ce63 100644 --- a/docs/ug/authorConfigSyntax.md +++ b/docs/ug/authorConfigSyntax.md @@ -9,7 +9,7 @@
-Given below are the advanced syntax available for `author-config.csv`. +Given below are the advanced syntax available for `author-config.csv`.
## Multiple `Repository's Location` per author diff --git a/docs/ug/usingReports.md b/docs/ug/usingReports.md index 7c19e8ba8c..ebe587bd2c 100644 --- a/docs/ug/usingReports.md +++ b/docs/ug/usingReports.md @@ -144,7 +144,7 @@ The `Code panel` allows users to see the code attributed to a specific author. C * Clicking the file title toggles the file content. * Clicking the first icon beside the file title opens the history view of the file on the remote repository. * Clicking the second icon beside the file title opens the blame view of the file on the remote repository. -* When using the code panel for a specific author, code attributed to the author is highlighted in green. +* When using the code panel for a specific author, code attributed to the author is highlighted in green. * When using the `merge group` option with `group by repos`, the code panel will consist of multiple authors' contributions. Code attributed to these authors can be differentiated by the highlight colors of the code. The color legend is shown at the top of each file and consists only those authors that edited a particular file. * Non-trivial code segments that the selected author has not written are hidden by default, but you can toggle them by clicking on the %%:fas-plus-circle:%% icon. diff --git a/frontend/src/components/c-summary-charts.vue b/frontend/src/components/c-summary-charts.vue index 7ebe313ddf..34f676bb88 100644 --- a/frontend/src/components/c-summary-charts.vue +++ b/frontend/src/components/c-summary-charts.vue @@ -27,11 +27,13 @@ ) | [{{ getGroupTotalContribution(repo) }} lines] span.tooltip-text( - v-if="filterGroupSelection === 'groupByRepos' && !isChartGroupWidgetMode" - )(v-bind:ref="`summary-charts-${i}-total-contribution`") Total contribution of group + v-if="filterGroupSelection === 'groupByRepos' && !isChartGroupWidgetMode", + v-bind:ref="`summary-charts-${i}-total-contribution`" + ) Total contribution of group span.tooltip-text( - v-else-if="filterGroupSelection === 'groupByAuthors' && !isChartGroupWidgetMode" - )(v-bind:ref="`summary-charts-${i}-total-contribution`") Total contribution of author + v-else-if="filterGroupSelection === 'groupByAuthors' && !isChartGroupWidgetMode", + v-bind:ref="`summary-charts-${i}-total-contribution`" + ) Total contribution of author a( v-if="!isGroupMerged(getGroupName(repo)) && !isChartGroupWidgetMode", v-on:click="handleMergeGroup(getGroupName(repo))"