Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changing chunk size & chunking scheme in settings #193

Open
samlhuillier opened this issue Apr 11, 2024 · 2 comments
Open

Support changing chunk size & chunking scheme in settings #193

samlhuillier opened this issue Apr 11, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@samlhuillier
Copy link
Collaborator

Chunk size is currently 500. This should not be hardcoded and users should be able to change this in settings.

Implementation:

  1. Add the property in store config for chunk size
  2. Use chunk size in Chunking.ts
  3. Add a page in settings to change this chunk size

An extension of this would be to change the chunking scheme; right now, markdown headings with # start a new note. Some users may not want that.

@samlhuillier samlhuillier added the good first issue Good for newcomers label Apr 11, 2024
@milaiwi
Copy link
Contributor

milaiwi commented May 7, 2024

Inside Chunking.ts, should we create a new Store<StoreSchema>() or modify the function to take in a pre-existing store, similar to how other functions do it?

@milaiwi
Copy link
Contributor

milaiwi commented May 10, 2024

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants