Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reor dock icon is larger than other icons. #184

Open
bearwithtea opened this issue Apr 4, 2024 · 8 comments
Open

Reor dock icon is larger than other icons. #184

bearwithtea opened this issue Apr 4, 2024 · 8 comments
Labels
good first issue Good for newcomers

Comments

@bearwithtea
Copy link
Contributor

The Reor icon appears to be larger than every other icon on the dock, which is visually unappealing.

Describe the solution you'd like
It would be nice for it to be a little bit smaller!

Additional context
Running this on an 2020 M1 Air, latest Reor release.

CleanShot 2024-04-04 at 08 40 52@2x

@samlhuillier samlhuillier added the good first issue Good for newcomers label Apr 4, 2024
@bearwithtea
Copy link
Contributor Author

@samlhuillier
not sure if you're the guy to talk to about this, but it looks like the current icon is 1280 x 1280 and MacOS standard is 1024 x 1024.

I have fixed it and can make a PR if the change is wanted.

@samlhuillier
Copy link
Collaborator

Yes that'd be great if you could push that up as a PR!

@bearwithtea
Copy link
Contributor Author

Alright, I will get that done tonight!

@prasadshreyas
Copy link

The Reor icon defaults to electron icon.

Additional context
2021 M1 Pro, latest Reor release

Screenshot 2024-04-04 at 7 36 35 PM

bearwithtea added a commit to bearwithtea/reor that referenced this issue Apr 4, 2024
Issue reorproject#184, icon is 1280 x 1280 when MacOS standard is 1024 x 1024.

Icon.icns file changed.
@bearwithtea bearwithtea mentioned this issue Apr 4, 2024
@bearwithtea
Copy link
Contributor Author

@samlhuillier

Alright, I just fired it off. I am still really new to open source in general, so please let me know if I messed anything up. I am happy to fix it and learn!

@bearwithtea
Copy link
Contributor Author

@prasadshreyas

Oh, that is interesting, I am not sure why that would be. Mine is still the Reor icon...

@prasadshreyas
Copy link

@bearwithtea I'm also surprised to see this. Will update after verifying with your PR

@bearwithtea
Copy link
Contributor Author

@prasadshreyas Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants