-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible race between setting config and deploying #1072
Labels
Comments
So, I think this is a legit race between deploying and setting config. When we deploy, we open a transaction and then lock the releases table to ensure that deployments are always sequential. However, this lock doesn't prevent Config objects from being changed. So it's still possible to grab the config from a previous release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We saw an instance today where a config var was set, then a deployment went out around the same time.
emp releases
shows something like this:However,
emp env
didn't show FOO. It appears that v1235 used the Config object from v1233 instead of v1234. Creating releases already should be acquiring a lock to prevent a race condition like this.The text was updated successfully, but these errors were encountered: