Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@rematch/core has incompatible types with react-redux@8 #976

Open
sushantdhiman opened this issue Aug 10, 2022 · 0 comments
Open

@rematch/core has incompatible types with react-redux@8 #976

sushantdhiman opened this issue Aug 10, 2022 · 0 comments

Comments

@sushantdhiman
Copy link
Contributor

Describe the bug

Typings are incompatible with latest react-redux@8

node_modules/@rematch/core/dist/types.d.ts:220:97 - error TS2304: Cannot find name 'MapStateToPropsParam'.

220         <RM extends Models<RM>, State, TStateProps, TDispatchProps, TOwnProps>(mapStateToProps: MapStateToPropsParam<TStateProps, TOwnProps, State>, mapDispatchToProps: MapRematchDispatchToPropsNonObject<TDispatchProps, TOwnProps, RM>): InferableComponentEnhancerWithProps<TStateProps & TDispatchProps, TOwnProps>;
                                                                                                    ~~~~~~~~~~~~~~~~~~~~

node_modules/@rematch/core/dist/types.d.ts:220:238 - error TS2304: Cannot find name 'InferableComponentEnhancerWithProps'.

220         <RM extends Models<RM>, State, TStateProps, TDispatchProps, TOwnProps>(mapStateToProps: MapStateToPropsParam<TStateProps, TOwnProps, State>, mapDispatchToProps: MapRematchDispatchToPropsNonObject<TDispatchProps, TOwnProps, RM>): InferableComponentEnhancerWithProps<TStateProps & TDispatchProps, TOwnProps>;

To Reproduce

If you try to compile any project with skipLibCheck: false using latest dependencies (example below), it will fail type check.

{
  "name": "rematch-test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "@rematch/core": "^2.2.0",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "react-redux": "^8.0.2",
    "redux": "^4.2.0",
    "typescript": "^4.7.4"
  }
}

Expected behavior

Compilation works without any errors

Additional context

Perhaps this type augmentation is no longer required

declare module 'react-redux' {
interface Connect {
<RM extends Models<RM>, State, TStateProps, TDispatchProps, TOwnProps>(
mapStateToProps: MapStateToPropsParam<TStateProps, TOwnProps, State>,
mapDispatchToProps: MapRematchDispatchToPropsNonObject<
TDispatchProps,
TOwnProps,
RM
>
): InferableComponentEnhancerWithProps<
TStateProps & TDispatchProps,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant