-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support processing sublist of tags #46
Labels
Comments
Hey! I don’t quite understand what you mean.
Which things?
Can you explain? Who thinks that? |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Initial checklist
Problem
Hello,
I am running my personal blog using unified and I am using this plugin.
The steps are as follow:
rehype-parse
andrehype-react
)ReactDOM.renderToString
The problem is I already have an existing unified pipeline that handles markdown with code snippets but this new process integrating with the react components is breaking some things.
I have many code samples on the site using Typescript etc and it thinks those are react components.
For Example:
Solution
I think it would be great to support a new options -
options.supportedTags
.What it will include: list of tags (ie
['p', 'a', ...]
)Type: Array
It will have the following behaviours:
Alternatives
I mean technically I can pass in all those tags into the
options.components
but that is a pain because every time I write a blog post with snippets using Typescript, I would need to update the list.I am open to other solutions though.
Let me know I can make a PR for this with tests.
I am happy to support it (It would be great to have for me) 🙏
The text was updated successfully, but these errors were encountered: